commit e6d516f6ade6cd53af5f1682153a74de3be14c45 Author: Steve Dickson Date: Sat Feb 8 09:13:25 2020 -0500 Release: 2.4.3 Signed-off-by: Steve Dickson commit faea15079d8386167aac14c09d316495fff8b726 Author: Kenneth D'souza Date: Sun Feb 9 14:39:49 2020 -0500 mountstats.man: Fix a typo in man page. Signed-off-by: Kenneth D'souza Signed-off-by: Steve Dickson commit 1eafe05616b4660fb15d106e06f0b3e18983708c Author: NeilBrown Date: Fri Feb 7 11:05:03 2020 -0500 Allow compilation to succeed with -fno-common When compiled with -fno-common, global variables that are declared multple times cause an error. With -fcommon (the default), they are merged. Declaring such variable multiple times is probably not a good idea, and is definitely not necessary. This patch changes all the global variables defined in include files to be explicitly "extern", and where necessary, adds the variable declaration to a suitable .c file. To test, run CFLAGS=-fno-common ./configure make Signed-off-by: NeilBrown Signed-off-by: Steve Dickson commit b5381c96298d75ba66625a007e2390e2b501850d Author: Trond Myklebust Date: Wed Jan 29 10:45:39 2020 -0500 manpage: Add a description of the 'softreval' / 'nosoftreval' mount option Add a description of the 'softreval' / 'nosoftreval' mount options on the 'nfs' generic manpage. Signed-off-by: Trond Myklebust Signed-off-by: Steve Dickson commit 3ff6fad27d2cd0772a40ddb65694ce04f3da83bc Author: Trond Myklebust Date: Wed Jan 29 10:42:03 2020 -0500 manpage: Add a description of the 'nconnect' mount option Add a description of the 'nconnect' mount option on the 'nfs' generic manpage. Signed-off-by: Trond Myklebust Signed-off-by: Steve Dickson commit 8eeaec5f26b5bb2255e2dd4551433f78cc515ccf Author: Steve Dickson Date: Fri Feb 7 10:18:21 2020 -0500 query_krb5_ccache: Removed dead code that was flagged by a covscan Signed-off-by: Steve Dickson commit 1fee8caa42138d2786a58d5c315743977694af6f Author: Giulio Benetti Date: Wed Jan 22 10:14:51 2020 -0500 locktest: Makefile.am: remove host compiler costraint Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments. Reviewed-by: Petr Vorel Tested-by: Petr Vorel Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 2f8417778b2a58b9a482b5f5e0769e97f3edc1d0 Author: Christian Bartolom?us Date: Thu Jan 16 15:47:57 2020 -0500 mountd: Remove outdated/misleading comment It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee ("mountd: fix mount issue due to comparison with uninitialized uuid") was applied back in 2015. The final case of the switch statement no longer ends with a 'return true' and the final 'return false' is relevant now. Signed-off-by: Christian Bartolom?us Signed-off-by: Steve Dickson commit 6eed99324f7e82d9b984349fd57f28f8094ed907 Author: Giulio Benetti Date: Thu Jan 16 15:31:01 2020 -0500 support: nfs: rpc_socket: silence unused parameter warning on salen If HAVE_LIBTIRPC is not defined salen parameter is unused and not taken into account, so compiler emits warning. Add a (void) salen; in that case. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 6e2dbc736f9805072a5683f87b3a83445a98c332 Author: Giulio Benetti Date: Thu Jan 16 15:28:27 2020 -0500 rpcgen: rpc_cout: silence format-nonliteral Silence format-nonliteral warning with #pragma GCC diagnostic ignored. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit e61775d1005845d5e5bda44a2630aa8bfa2c2d8c Author: Giulio Benetti Date: Thu Jan 16 15:25:07 2020 -0500 rpcgen: bump to latest version Bump rpcgen to latest version keeping as upstream: https://github.com/thkukuk/rpcsvc-proto Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit c2fb6f84e2c8ab9c37f9fc0f26624ea4ea1abd91 Author: Steve Dickson Date: Thu Jan 16 09:16:06 2020 -0500 statd: Fix permission denied error path Commit 2dcce8ec introduced setting a pointer to NULL which causes statd to crash when the state directories have the incorrect permissions Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1776096 Signed-off-by: Steve Dickson commit 6db16a20592fc3add1472a3eadf8a6161358a2eb Author: Giulio Benetti Date: Mon Jan 6 14:24:48 2020 -0500 rpcgen: rpc_hout: fix indentation on f_print() argument separator Remove useless space before closing parenthesys. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 6f4568f1f7395f967cc03995dcfb79a1ac5c11cd Author: Giulio Benetti Date: Mon Jan 6 14:23:04 2020 -0500 rpcgen: rpc_hout: fix potential -Wformat-security warning f_print()'s argument "separator" is not known because it's passed as an argument and with -Wformat-security will cause a useless warning. Let's ignore by adding "#pragma GCC diagnostic ignored/warning" before and after f_print(). Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 2df6b22175f8415750402972c65cb9a8a28cf194 Author: Giulio Benetti Date: Mon Jan 6 14:19:28 2020 -0500 rpcgen: rpc_parse: add get_definition() void argument get_definition() prototype has no arguments and this can cause warnings during building. Let's add void argument to prototype according to its implementation. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 653548974e96114a50466a115cdb456030b86c73 Author: Giulio Benetti Date: Mon Jan 6 14:18:00 2020 -0500 pcgen: rpc_util: add findval args to prototype findval() prototype has no arguments and this can cause warnings during building. Let's add its arguments to prototype according to its implementation. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit dc416b171cb52cb09aef6ba80da8b5e469ee01da Author: Giulio Benetti Date: Mon Jan 6 14:15:56 2020 -0500 rpcgen: rpc_util: add storeval args to prototype storeval() prototype has no arguments and this can cause warnings during building. Let's add its arguments to prototype according to its implementation. Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 4cf5058339a9868637ae74ea5fd56bc057fe804d Author: Giulio Benetti Date: Mon Jan 6 14:14:14 2020 -0500 rpcgen: rpc_cout: silence unused def parameter In emit_enum() argument def is not used and can cause a warning. So let's mark it with __attribute__((unused)). Signed-off-by: Giulio Benetti Signed-off-by: Steve Dickson commit 03d80376e00e23312c4b1fcb187aed8fa210bbec Author: Markus Schaaf Date: Fri Jan 3 11:20:04 2020 -0500 gssd: Use setgroups32 syscall, if available. This closes a bug on older 32-bit platforms, where the 16-bit setgroups syscall has been replaced by setgroups32 and is not available anymore. Fixes: https://bugzilla.linux-nfs.org/show_bug.cgi?id=340 Signed-off-by: Markus Schaaf Signed-off-by: Steve Dickson commit 0095435db8228d5a88ec35a63cb64271e2e648a8 Author: Steve Dickson Date: Thu Dec 19 12:48:31 2019 -0500 libnfsidmap: Turn off default verbosity Commit f080188e changed the library's verbosity to be on by default. The patch turns it off by default Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1774787 Signed-off-by: Steve Dickson commit bca434a337e5de47cd5c623a270c31d53d4b799f Author: Olga Kornievskaia Date: Wed Dec 18 09:31:07 2019 -0500 gssd: force getting tgt if ticket cache was removed If ticket cache was removed manually, but gssd thinks it has a valid credentials it will fail mount creation as it can't get a service ticket (due to lack of the tgt). Check if file-based ticket cache is not there and set the "nocache" to 1 forcing the client to get a new tgt. Signed-off-by: Olga Kornievskaia Signed-off-by: Steve Dickson commit 67946c288b6d36b46b3a44f52c2204af3bfbf09c Author: Thomas Petazzoni Date: Wed Dec 11 13:34:42 2019 -0500 configure.ac: Let the configure script find getrpcbynumber in libtirpc The getrpcbynumber() function may not be available in the C library, but only in the libtirpc library. Take this into account when checking for the existence of getrpcbynumber() and getrpcbynumber_r(). Reviewed-by: Petr Vorel [ pvorel: patch taken from Buildroot distribution ] Signed-off-by: Petr Vorel Signed-off-by: Thomas Petazzoni Signed-off-by: Steve Dickson commit ff3ad88c233ecd87f7983ad13836323f944540ec Author: Doug Nazar Date: Mon Dec 9 10:53:37 2019 -0500 Disable statx if using glibc emulation On older kernels without statx, glibc with statx support will attempt to emulate the call. However it doesn't support AT_STATX_DONT_SYNC and will return EINVAL. This causes all xstat/xlstat calls to fail. Signed-off-by: Doug Nazar Signed-off-by: Steve Dickson commit dc50aaf0e958983ce04337a93e505706ab9aa3d3 Author: Scott Mayhew Date: Mon Dec 9 10:43:19 2019 -0500 nfsdcld: getopt_long() returns an int, not a char This was causing nfsdcld to spit out a usage message instead of starting up on non-x86_64 arches. Signed-off-by: Scott Mayhew Signed-off-by: Steve Dickson commit 56a7f1e1be915ffd5b1ee4f61c2b96a60aae6f34 Author: Scott Mayhew Date: Mon Dec 9 10:39:42 2019 -0500 systemd: install nfsdcld.service when nfsdcld is enabled Signed-off-by: Scott Mayhew Signed-off-by: Steve Dickson commit 53921630292c12adb3920e9dfa1da9b899b5f57b Author: Scott Mayhew Date: Mon Dec 9 10:36:49 2019 -0500 nfsdcld: don't override sbindir According to the guidelines in hier(7), nfsdcld should live in /usr/sbin and not /sbin. Plus, the nfsdcld.service systemd unit file is looking for it in /usr/sbin. Signed-off-by: Scott Mayhew Signed-off-by: Steve Dickson commit 638855b458e62ad2f1068d90b44dc5700c0bf8f1 Author: Frederik Pasch Date: Fri Nov 22 13:24:33 2019 -0500 Switch legacy index() in favour of strchr() This fixes build on musl, which has index() only in legacy (not in unlike glibc/uclibc). [ gustavo: rebased to 1.2.6 ] Signed-off-by: Gustavo Zacarias [ pvorel: taken from Buildroot distribution, rebased ] Reviewed-by: Petr Vorel Signed-off-by: Petr Vorel Signed-off-by: Frederik Pasch Signed-off-by: Steve Dickson commit f57d955c9ce6e208ac40fc78d6b23c8bd09c3755 Author: Petr Vorel Date: Fri Nov 22 13:05:47 2019 -0500 mount: Fix return 0 from void function Fixes: d5e30346 ("mount: Do not overwrite /etc/mtab if it's symlink") Signed-off-by: Petr Vorel Signed-off-by: Steve Dickson commit d5e303461846a5c7282b819fb729760bef472d89 Author: Joey Hess Date: Fri Nov 22 10:31:13 2019 -0500 mount: Do not overwrite /etc/mtab if it's symlink Some systems have /etc/mtab symlink to /proc/mounts. In that case mount.nfs complains: Can't set permissions on mtab: Operation not permitted See https://bugs.debian.org/476577 This change makes mount.nfs handle symlinked /etc/mtab the way umount.nfs and util- linux handle it. Cc: Chuck Lever Signed-off-by: Joey Hess [ pvorel: took patch from Debian, rebased for 2.4.3-rc1 and created commit message. Patch is also used in Gentoo. ] Signed-off-by: Petr Vorel Signed-off-by: Steve Dickson commit f7c0c0dc4a02d87965d3fbbab69786ca07fdecea Author: Guillaume Rousse Date: Fri Nov 22 10:20:03 2019 -0500 fix compilation with -Werror=format on i586 Signed-off-by: Steve Dickson commit a20dbec98f46c53596646cafca1051cf351ed3a4 Author: Doug Nazar Date: Fri Nov 22 10:17:38 2019 -0500 nfsdcld: Fix printf format strings on 32bit Signed-off-by: Steve Dickson commit 31bb484b22c220c561f3a95c3b7ca3ea9b96cc9b Author: Petr Vorel Date: Mon Nov 18 11:27:19 2019 -0500 mountd: Fix compilation for --disable-uuid Although code in configure.ac pretends to set USE_BLKID as 0 via AC_DEFINE_UNQUOTED, it's actually not defined support/include/config.h.in support/include/config.h /* #undef USE_BLKID */ Fixes: 8e643554 ("Allow disabling of libblkid usage.") Signed-off-by: Petr Vorel Signed-off-by: Steve Dickson commit f100d07d923b5db60d42dc2453485fa0dba69a79 Author: Petr Vorel Date: Mon Nov 18 08:58:36 2019 -0500 mountd: Add check for 'struct file_handle' From: Maxime Hadjinlian The code to check if name_to_handle_at() is implemented generates only a warning but with some toolchain it doesn't fail to link (the function must be implemented somewhere). However the "struct file_handle" type is not available. So, this patch adds a check for this struct. Patch taken from buildroot distribution. Signed-off-by: Thomas Petazzoni [ pvorel: rebased from nfs-utils-1-3-4 ] Signed-off-by: Petr Vorel Signed-off-by: Maxime Hadjinlian Signed-off-by: Steve Dickson commit 55185d07ead736fb2cb9e6ec5ae5caba42a7f056 Author: Petr Vorel Date: Mon Nov 18 08:51:40 2019 -0500 autoconf: Add Debian paths for Kerberos v5 with GSS Debian stores it's shared libraries in /usr/lib/$(uname -m)-linux-gnu Signed-off-by: Petr Vorel Signed-off-by: Steve Dickson commit 1378280398ef9f5cd45f5542ae2945b9a360b132 Author: Doug Nazar Date: Sun Nov 17 14:31:33 2019 -0500 Ensure consistent struct stat definition Although 2fbc62e2a13fc ("Fix include order between config.h and stat.h") reorganized those files that were already including config.h, not all files were including config.h. Fixes at least stack smashing crashes in mountd on 32-bit systems. Signed-off-by: Doug Nazar Signed-off-by: Steve Dickson