commit 32da801cb697919f79f45695aeb568b53ad166a8 Author: Steve Dickson Date: Thu Sep 6 11:51:52 2018 -0400 tcp-wrappers.m4: Only look for TCP wrappers lib when requested TCP wrappers is a pretty old and obsolete technology. The support has be terminated in current distro release, so only require the library to exist when asked for via the --with-tcp-wrappers Signed-off-by: Steve Dickson commit 86604e2bd536ea48832dd0bf3d95b15de4de2733 Author: Steve Dickson Date: Thu Sep 6 10:22:11 2018 -0400 statd: fix use-after-free in monitor list if insertion fails If nsm_insert_monitored_host() fails while saving the record to stable storage, we can't just assume the entry was new. Existing records must be removed from the list before being freed. Reviewed-by: Chuck Lever Signed-off-by: Frank Sorenson Signed-off-by: Steve Dickson commit edb11a82afaeda0d911e2cefeb50f0d6157e0426 Author: Scott Mayhew Date: Mon Aug 20 08:56:05 2018 -0400 nfsd: track when the user explicitly requested version 4.0 Since both 'rpc.nfsd -V4' and 'rpc.nfsd -V4.0' alter bit 0 in 'minorversset' and 'minorvers', it's not possible to know whether the user explicitly requested version 4.0 or not. Add another variable 'force4dot0' to track when the user explicitly requested version 4.0 so that we can write '4.0' to /proc/fs/nfsd/versions on kernel versions 4.11 and higher. On earlier kernels, we'll still write '4' as in the past. Signed-off-by: Scott Mayhew Signed-off-by: Steve Dickson commit 5ee8665a53dc70f18f367bfd681378ad9ea5a663 Author: Scott Mayhew Date: Mon Aug 20 08:44:08 2018 -0400 nfsd: allow verson 4.0 to be enabled/disabled via nfs.conf The nfs.conf file has a 'vers4.0' parameter, but nfsd doesn't currently check it. Signed-off-by: Scott Mayhew Signed-off-by: Steve Dickson commit 327446213593070733702aaab92045c46452e0c1 Author: Yongcheng Yang Date: Sat Jul 21 08:25:44 2018 -0400 rpc.gssd: fix typo checking "__NR_setresuid32" instead of "__NR_setresgid32 Signed-off-by: Yongcheng Yang Signed-off-by: Steve Dickson commit 2a6b8307fa4243a7921270aedf8ce6506e31569a Author: Steve Dickson Date: Tue Jul 17 15:09:37 2018 -0400 rpc.gssd: truncates 32-bit UIDs/GIDs to 16 bits architectures. utils/gssd_proc.c uses SYS_setresuid and SYS_setresgid in change_identity when it should use SYS_setresuid32 and SYS_setresgid32 instead. This causes it to truncate UIDs/GIDs > 65536. Fixes: https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1779962 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1595927 Tested-by: James Ettle Tested-by: Sree Signed-off-by: Steve Dickson commit 3d0e59c63c9957d8cbca26f88bac1784d835e019 Author: Steve Dickson Date: Tue Jul 10 14:19:30 2018 -0400 Fixed typo in nfsmount.conf Signed-off-by: Steve Dickson commit 5743891761f99bdfe6bf89956dab3a0e4c8a0fd0 Author: Steve Dickson Date: Wed Jun 27 12:42:05 2018 -0400 Revert "gssd.c: Remomved a couple of warning errors" This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d. Added back the 'm' character which cause memory to be allocated for the string convertions. Signed-off-by: Steve Dickson commit 2dddcbd3a605ba6a2ab1a39a374e5671317ad520 Author: Yongcheng Yang Date: Mon Jun 25 11:19:47 2018 -0400 nfsstat: fix typo causing --mounts unrecognized option This reverts commit acf95d32a44fd8357c24e8a04ec53fc6900bfc58 Signed-off-by: Yongcheng Yang Signed-off-by: Steve Dickson commit 2cb5dc423b7f4c4d7e2722722f0f943b1c4377ba Author: Kenneth D'souza Date: Mon Jun 25 11:08:34 2018 -0400 nfs-utils: Fix minor memory leaks before return. Signed-off-by: Kenneth D'souza Signed-off-by: Frank Sorenson Signed-off-by: Steve Dickson commit 966264bb1160f8d403cf21001890d1d3336e559b Author: Justin Mitchell Date: Mon Jun 25 11:04:06 2018 -0400 nfs-utils: Spelling fixes Fix some typos in the nfs.conf related code Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit 4eac7e6481eaadbcceba93b779db1e37ecd71319 Author: Justin Mitchell Date: Mon Jun 25 11:02:22 2018 -0400 nfs-utils: Add config setting to nfsconf cli tool Use the new conf_write() function to add setting and unsetting of config file values to the cli tool Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit 8fa5a6b596cccdc609cca4fc25c9964ef9c34775 Author: Justin Mitchell Date: Mon Jun 25 11:01:04 2018 -0400 nfs-utils: Add config file writing function Adds a function to nfsconf handling to write a single config entry, creating the file and section headers as required. Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit 4c353967bd219cfaa4c98ca617f85a7cb84babb1 Author: Justin Mitchell Date: Mon Jun 25 10:58:42 2018 -0400 nfs-utils: swap xlog_err for less fatal version Use of xlog_err is immediately fatal, switch to using xlog(L_ERROR, ...) instead so that the error handling and cleanup mechanisms can operate properly Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit 77eca8d14f52eb8bcfed77e68a7fc862d02ecdfb Author: Justin Mitchell Date: Mon Jun 25 10:57:18 2018 -0400 nfs-utils: Fix comparison check for subsection headers When comparing two config section headers it incorrectly handled matching section names where only one had a subsection value Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit e10bfe08cc4f0165e87b8c797270dfd3b169945d Author: Justin Mitchell Date: Mon Jun 25 10:55:41 2018 -0400 nfs-utils: Ignore empty lines in config The test for empty lines didn't ignore whitespace properly Signed-off-by: Justin Mitchell Signed-off-by: Steve Dickson commit a1f4e16d0426274d15c785ead3584bb7f9df32fd Author: Steve Dickson Date: Sun Jun 24 14:21:24 2018 -0400 nfsdcltrack: getopt_long() fails on a non x86_64 archs getopt_long() returns an int, not char, which matters on non-x86_64 archs since a char is signed on x86_64 arch but unsigned on other archs. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1551903 Signed-off-by: Steve Dickson commit 618045f25962ed9eeb6937fb967bf5aca36000af Author: Kenneth D'souza Date: Tue Jun 19 12:41:07 2018 -0400 nfs-utils: Fix a minor memory leak in generate_mount_unit and generate_target Free allocated memory for path before return. Signed-off-by: Kenneth D'souza Signed-off-by: Steve Dickson commit 2ece1b6a6a8ecfb6767e65f68f5f8d2c17fce6e8 Author: J. Bruce Fields Date: Tue Jun 19 12:37:56 2018 -0400 exports: document change to "insecure" export option We're changing the kernel to allow gss requests from high ports even when "secure" is set. If the change gets backported to distro kernels, the kernel version may be an imperfect predictor of the behavior, but I think it's the best we can do. Signed-off-by: J. Bruce Fields Signed-off-by: Steve Dickson commit c5c4b34e92815ef4da77df40293883ab8fed39f7 Author: Olga Kornievskaia Date: Tue Jun 19 12:35:23 2018 -0400 nfs(5): update clientaddr value options Document the use of IPv4/IPv6_ANY address as values to the clientaddr as a way to tell the server that the client does not want delegations. Signed-off-by: Olga Kornievskaia Signed-off-by: Steve Dickson commit c6ea4d1e02ea04793ef36763ffad715c8f2ac34c Author: Olga Kornievskaia Date: Tue Jun 19 12:34:17 2018 -0400 Add check of clientaddr argument If the NFS client administrator supplies the clientaddr mount option, it should be either a special value of either IPv4/IPv6 any address or one of the machine's network addresses. Otherwise, warn the administrator about the use of an arbitrary value for the clientaddr value. Signed-off-by: Olga Kornievskaia Signed-off-by: Steve Dickson commit 1aac77cbc8af2bb636356f47a99b892082370c69 Author: Steve Dickson Date: Tue Jun 5 11:28:02 2018 -0400 Remove a number of stringop-overflow warnings umich_ldap.c:1128:3: warning: ‘strncat’ specified bound 128 equals destination size [-Wstringop-overflow=] umich_ldap.c:1130:3: warning: ‘strncat’ specified bound 128 equals destination size [-Wstringop-overflow=] idmapd.c:313:2: warning: ‘strncat’ specified bound 4096 equals destination size [-Wstringop-overflow=] Signed-off-by: Steve Dickson commit 1dbd8776a5cbb0dc9cd75d97a0535d8c51458f6b Author: Steve Dickson Date: Tue Jun 5 11:20:05 2018 -0400 Remove a number of stringop-truncation warnings client.c:486:3: warning: ‘strncpy’ destination unchanged after copying no bytes [-Wstringop-truncation] file.c:99:2: warning: ‘strncpy’ specified bound 4096 equals destination size [-Wstringop-truncation] v4root.c:95:2: warning: ‘strncpy’ specified bound 1025 equals destination size [-Wstringop-truncation] sm-notify.c:572:3: warning: ‘strncpy’ specified bound 1025 equals destination size [-Wstringop-truncation] nfs4mount.c:221:3: warning: ‘strncpy’ specified bound 1024 equals destination size [-Wstringop-truncation] nfsmount.c:831:2: warning: ‘strncpy’ specified bound 256 equals destination size [-Wstringop-truncation] Signed-off-by: Steve Dickson commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d Author: Steve Dickson Date: Fri Jun 1 10:18:35 2018 -0400 gssd.c: Remomved a couple of warning errors gssd.c:291:7: error: ISO C does not support the 'm' scanf flag [-Werror=format=] gssd.c:291:7: error: format '%s' expects argument of type 'char *', but argument 4 has type 'char **' [-Werror=format=] Signed-off-by: Steve Dickson commit b6aa1a05f21f564ae57148d1b34b6071d3476d04 Author: Steve Dickson Date: Fri Jun 1 09:40:45 2018 -0400 Removed format expects argument of type errors idmapd.c: In function 'getfield': idmapd.c:936:4: error: format '%o' expects argument of type 'unsigned int *', but argument 3 has type 'int *' [-Werror=format=] if ((n = sscanf(bp, "\\%03o", &val)) != 1) nfsidmap.c: In function 'key_invalidate': nfsidmap.c:322:3: error: format '%x' expects argument of type 'unsigned int *', but argument 3 has type 'key_serial_t *' [-Werror=format=] sscanf(buf, "%x", &key); Signed-off-by: Steve Dickson commit 62e2963d12d3fb25330c96af1c555c792d7372d0 Author: Steve Dickson Date: Fri Jun 1 09:34:14 2018 -0400 Removed ISO C does not support the '%m' gnu_printf format errors nfsstat.c: In function 'mounts': nfsstat.c:1016:3: error: ISO C does not support the '%m' gnu_printf format [-Werror=format=] fprintf(stderr, "Warning: %s: %m\n", name); ^ nfsstat.c: In function 'get_stats': nfsstat.c:1093:6: error: ISO C does not support the '%m' gnu_printf format [-Werror=format=] label, file); statd.c: In function 'set_nlm_port': statd.c:235:5: error: ISO C does not support the '%m' gnu_printf format [-Werror=format=] name_p, type); ^ statd.c:238:3: error: ISO C does not support the '%m' gnu_printf format [-Werror=format=] fprintf(stderr, "%s: failed to open %s: %m\n", name_p, pathbuf); Signed-off-by: Steve Dickson commit 649b76acf20f192ddb78492e72bdc3051aa4dcce Author: Steve Dickson Date: Fri Jun 1 09:27:41 2018 -0400 xtab.c: Removed overflow in implicit constant conversion errors xtab.c: In function 'xtab_read': xtab.c:60:4: error: overflow in implicit constant conversion [-Werror=overflow] exp->m_xtabent = 1; ^ xtab.c:61:4: error: overflow in implicit constant conversion [-Werror=overflow] exp->m_mayexport = 1; Signed-off-by: Steve Dickson commit c3b776b8f198427bebc2e1b2eeec70b91894ccad Author: gabriele balducci Date: Thu May 31 11:18:15 2018 -0400 Fixed format overflow warnings in mountd and nfsd Signed-off-by: Steve Dickson commit fd5ccdc449a0ef79498191aecb3e44120e813618 Author: Steve Dickson Date: Thu May 31 11:02:58 2018 -0400 rpcgen: Only compile the command when configured. Only compile and use the internal rpcgen when required via the --with-rpcgen flag It is strongly suggested to use the rpcgen from the new created rpcsvc-proto package be used. Signed-off-by: Steve Dickson commit 67ee7c1947f5be4eb6b7fea1a2d5dff9f339f15e Author: Chuck Lever Date: Tue Jun 5 10:39:51 2018 -0400 gssd: Add "srchost=" upcall parameter The callback client used by NFSv4.0 servers to send CB calls has to use a source principal that is the same as the target principal that the client used to establish the forward channel. In multi-homed server set-ups, the domain part of the principal's hostname may not be the same as server's DNS domain. So gssd can no longer assume that. The kernel can scrape that domain off the forward channel's principal and pass that up to gssd. This patch adds a new parameter, "srchost", to the kernel upcall. When the kernel presents this new parameter in an upcall, gssd will use it, along with the "service" parameter, to construct the service principal for the keytab lookup. Signed-off-by: Chuck Lever Signed-off-by: Steve Dickson