From aedc55bc48cc8431517a8177ae860110fd8b3e2c Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Sat, 8 Oct 2022 04:56:37 +0300 Subject: [PATCH 41/41] citizens_update(): Remove redundant and broken check Reported by ihnatus See osdn #44852 Signed-off-by: Marko Lindqvist --- server/citizenshand.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/citizenshand.c b/server/citizenshand.c index 118e5554f0..1e1c58f87c 100644 --- a/server/citizenshand.c +++ b/server/citizenshand.c @@ -263,10 +263,7 @@ void citizens_update(struct city *pcity, struct player *plr) delta++; citizens_nation_set(pcity, pslot, 0); /* Remove this nation from the list of nationalities. */ - if (selected != count) { - city_nations[selected] = city_nations[count - 1]; - } - count--; + city_nations[selected] = city_nations[--count]; log_citizens_add(pcity, -1, pplayer); } else { -- 2.35.1