From c550f99efd758c8899659cecd1a11d3e832964dd Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Tue, 31 May 2022 00:23:52 +0300 Subject: [PATCH 46/46] savegame3.c: Really stop orders handling when target extra is missing The continued handling could have resulted in illegal memory access. Reported anonymously See osdn #44728 Signed-off-by: Marko Lindqvist --- server/savegame/savegame3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/savegame/savegame3.c b/server/savegame/savegame3.c index 00dc7c276d..e091fbbe3b 100644 --- a/server/savegame/savegame3.c +++ b/server/savegame/savegame3.c @@ -6185,6 +6185,7 @@ static bool sg_load_player_unit(struct loaddata *loading, free(punit->orders.list); punit->orders.list = NULL; punit->has_orders = FALSE; + break; } } else if (order->order != ORDER_PERFORM_ACTION) { if (order_sub_tgt != -1) { -- 2.35.1