From ad02b405db6903bc5670381963e71d2fcc597442 Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Wed, 23 Mar 2022 18:36:59 +0200 Subject: [PATCH 8/8] broadcast_city_info(): Send info to all players, not to owner multiple times Info was being sent to owner once for each other player that could see city internals, also when the info was not meant to be sent to owner at all. It was not sent to those other players who it was meant to. Reported by Lexxie See osdn #44158 Signed-off-by: Marko Lindqvist --- server/citytools.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/citytools.c b/server/citytools.c index e864ae0dd7..e8f94bc69f 100644 --- a/server/citytools.c +++ b/server/citytools.c @@ -2102,8 +2102,8 @@ void broadcast_city_info(struct city *pcity) players_iterate(pplayer) { if (can_player_see_city_internals(pplayer, pcity)) { if (!send_city_suppressed || pplayer != powner) { - update_dumb_city(powner, pcity); - lsend_packet_city_info(powner->connections, &packet, FALSE); + update_dumb_city(pplayer, pcity); + lsend_packet_city_info(pplayer->connections, &packet, FALSE); } } else { if (player_can_see_city_externals(pplayer, pcity)) { -- 2.35.1