From be3f74869b9b07c5d731bd2c9645511d832996c6 Mon Sep 17 00:00:00 2001 From: Alina Lenk Date: Wed, 2 Mar 2022 15:14:29 +0100 Subject: [PATCH 1/5] generate_packets.py: Replace range(len()) with enumerate() See osdn #44007 Signed-off-by: Alina Lenk --- common/generate_packets.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/common/generate_packets.py b/common/generate_packets.py index 902fb8344e..e994586e62 100755 --- a/common/generate_packets.py +++ b/common/generate_packets.py @@ -1267,8 +1267,7 @@ static char *stats_%(name)s_names[] = {%(names)s}; } ''' body="" - for i in range(len(self.other_fields)): - field=self.other_fields[i] + for i, field in enumerate(self.other_fields): body=body+field.get_cmp_wrapper(i) if self.gen_log: fl=' %(log_macro)s(" no change -> discard");\n' @@ -1297,8 +1296,7 @@ static char *stats_%(name)s_names[] = {%(names)s}; body=body+field.get_put(1)+"\n" body=body+"\n" - for i in range(len(self.other_fields)): - field=self.other_fields[i] + for i, field in enumerate(self.other_fields): body=body+field.get_put_wrapper(self,i,1) body=body+''' *old = *real_packet; @@ -1413,8 +1411,7 @@ static char *stats_%(name)s_names[] = {%(names)s}; } '''%self.get_dict(vars()) - for i in range(len(self.other_fields)): - field=self.other_fields[i] + for i, field in enumerate(self.other_fields): body=body+field.get_get_wrapper(self,i,1) extro=''' @@ -1587,8 +1584,7 @@ class Packet: all_caps=all_caps.keys() choices=get_choices(all_caps) self.variants=[] - for i in range(len(choices)): - poscaps=choices[i] + for i, poscaps in enumerate(choices): negcaps=without(all_caps,poscaps) fields=[] for field in self.fields: -- 2.17.1