https://github.com/madler/zlib/pull/599 Rebased version of: From 37c9730ba474d274f4cc6a974943eef95087b9f6 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Tue, 8 Mar 2022 22:38:47 -0800 Subject: [PATCH] configure: Pass LDFLAGS to link tests LDFLAGS can contain critical flags without which linking wont succeed therefore ensure that all configure tests involving link time checks are using LDFLAGS on compiler commandline along with CFLAGS to ensure the tests perform correctly. Without this some tests may fail resulting in wrong confgure result, ending in miscompiling the package Signed-off-by: Khem Raj k --- a/configure +++ b/configure @@ -448,8 +448,8 @@ EOF if test $shared -eq 1; then echo Checking for shared library support... | tee -a configure.log # we must test in two steps (cc then ld), required at least on SunOS 4.x - if try $CC -c $SFLAGS $test.c && - try $LDSHARED $SFLAGS -o $test$shared_ext $test.o; then + if try $CC -c $SFLAGS $LDFLAGS $test.c && + try $LDSHARED $SFLAGS $LDFLAGS -o $test$shared_ext $test.o; then echo Building shared library $SHAREDLIBV with $CC. | tee -a configure.log elif test -z "$old_cc" -a -z "$old_cflags"; then echo No shared library support. | tee -a configure.log @@ -511,7 +511,7 @@ int main(void) { } EOF fi - if try $CC $CFLAGS -o $test $test.c; then + if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then sizet=`./$test` echo "Checking for a pointer-size integer type..." $sizet"." | tee -a configure.log CFLAGS="${CFLAGS} -DNO_SIZE_T=${sizet}" @@ -545,7 +545,7 @@ int main(void) { return 0; } EOF - if try $CC $CFLAGS -o $test $test.c; then + if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then echo "Checking for fseeko... Yes." | tee -a configure.log else CFLAGS="${CFLAGS} -DNO_FSEEKO" @@ -562,7 +562,7 @@ cat > $test.c < int main() { return strlen(strerror(errno)); } EOF -if try $CC $CFLAGS -o $test $test.c; then +if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then echo "Checking for strerror... Yes." | tee -a configure.log else CFLAGS="${CFLAGS} -DNO_STRERROR" @@ -669,7 +669,7 @@ int main() return (mytest("Hello%d\n", 1)); } EOF - if try $CC $CFLAGS -o $test $test.c; then + if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then echo "Checking for vsnprintf() in stdio.h... Yes." | tee -a configure.log echo >> configure.log @@ -759,7 +759,7 @@ int main() } EOF - if try $CC $CFLAGS -o $test $test.c; then + if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then echo "Checking for snprintf() in stdio.h... Yes." | tee -a configure.log echo >> configure.log